fix: point release-please at convex-sync package#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-pleaseat the real CLI package instead of the virtual workspace rootRoot Cause
mainwas still failingrelease / 01-release-pleaseafter#10.The failure moved past the package-version issue and then died because the config still targeted
"."while the workspace root is a virtual Cargo manifest with no[package.name].Changes
release-please-config.jsonpackage path from.toapps/convex-sync.release-please-manifest.jsonto:{"apps/convex-sync": "0.0.1"}apps/convex-sync/CHANGELOG.mdCHANGELOG.mdVerification
cargo fmt --all --checkcargo test --workspacecargo run -p convex-sync -- --versionactionlint -config-file .github/actionlint.yaml .github/workflows/*.yml .depot/workflows/*.ymlnpx -y release-please debug-config --local --local-path . --repo-url shpitdev/convex-streaming-olap-export --target-branch fix/release-please-package-path --config-file release-please-config.json --manifest-file .release-please-manifest.json --dry-runrepositoryConfignow keys onapps/convex-syncreleasedVersions["apps/convex-sync"] == 0.0.1