Skip to content

fix: point release-please at convex-sync package#11

Merged
anandpant merged 1 commit into
mainfrom
fix/release-please-package-path
Apr 20, 2026
Merged

fix: point release-please at convex-sync package#11
anandpant merged 1 commit into
mainfrom
fix/release-please-package-path

Conversation

@anandpant

@anandpant anandpant commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • point release-please at the real CLI package instead of the virtual workspace root
  • seed the release manifest with the current CLI version
  • move the maintained changelog to the CLI package path

Root Cause

main was still failing release / 01-release-please after #10.

The failure moved past the package-version issue and then died because the config still targeted "." while the workspace root is a virtual Cargo manifest with no [package.name].

Changes

  • change release-please-config.json package path from . to apps/convex-sync
  • set .release-please-manifest.json to:
    • {"apps/convex-sync": "0.0.1"}
  • add apps/convex-sync/CHANGELOG.md
  • remove the now-unused root CHANGELOG.md

Verification

  • cargo fmt --all --check
  • cargo test --workspace
  • cargo run -p convex-sync -- --version
  • actionlint -config-file .github/actionlint.yaml .github/workflows/*.yml .depot/workflows/*.yml
  • npx -y release-please debug-config --local --local-path . --repo-url shpitdev/convex-streaming-olap-export --target-branch fix/release-please-package-path --config-file release-please-config.json --manifest-file .release-please-manifest.json --dry-run
    • confirmed repositoryConfig now keys on apps/convex-sync
    • confirmed releasedVersions["apps/convex-sync"] == 0.0.1

Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@anandpant
anandpant merged commit 04e5671 into main Apr 20, 2026
7 checks passed
@anandpant
anandpant deleted the fix/release-please-package-path branch April 20, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant